Improve docker setup

- add entrypoint script
- add .dockerignore
- fix shellcheck warnings in gvafile.sh
- migrate to Celery 5 settings
- downgrade importlib-metadata for Celery compatibility

.dockerignore

@@ -0,0 +1,17 @@
+**/*.pyc
+**/.*.swp
+**/.coverage
+**/__pycache__
+.dockerignore
+.env
+.envrc
+.git
+.gitignore
+.idea
+.vagrant
+Dockerfile
+Vagrantfile
+change-vmdebootstrap-default-dhcp.sh
+coverage-report
+docs
+salt

Dockerfile

@@ -57,10 +57,8 @@ RUN addgroup --gid $GVAGID $GVAAPP ; \
 
 COPY --chown=$GVAAPP:$GVAAPP --from=builder /srv/$GVAAPP/.venv /srv/$GVAAPP/.venv
 
-USER $GVAAPP
+VOLUME /srv/$GVAAPP/$GVAAPP
 
-VOLUME /srv/$GVAAPP
+COPY ${GVAAPP}.sh entrypoint.sh /srv/
 
-COPY ${GVAAPP}.sh /srv/
+ENTRYPOINT ["dumb-init", "/srv/entrypoint.sh"]
-
-ENTRYPOINT ["dumb-init", "/srv/${GVAAPP}.sh"]

entrypoint.sh

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+set -e
+
+su -c /srv/gvafile.sh gvafile

gvafile.sh

@@ -2,10 +2,10 @@
 
 set -e
 
-QUEUE=file
+QUEUE="file"
-TASKS=fileservertasks
+TASKS="fileservertasks"
-APP=gvafile
+APP="gvafile"
 
 . "/srv/${APP}/.venv/bin/activate"
 cd /srv/${APP}/${APP}
-celery -A "${TASKS}" worker -Q "${QUEUE}" -l info
+celery -A "${TASKS}" worker -Q "${QUEUE}" -E -l info

gvafile/fileservertasks/settings.py

@@ -25,16 +25,16 @@ def get_env_variable(setting):
 
 
 ########## CELERY CONFIGURATION
-CELERY_BROKER_URL = get_env_variable("GVAFILE_BROKER_URL")
+accept_content = ["json"]
-CELERY_RESULT_BACKEND = get_env_variable("GVAFILE_RESULTS_REDIS_URL")
+broker_url = get_env_variable("GVAFILE_BROKER_URL")
-CELERY_RESULT_PERSISTENT = True
+enable_utc = True
-CELERY_TASK_RESULT_EXPIRES = None
+result_backend = get_env_variable("GVAFILE_RESULTS_REDIS_URL")
-CELERY_ROUTES = ("gvacommon.celeryrouters.GvaRouter",)
+result_expires = None
-CELERY_TIMEZONE = "Europe/Berlin"
+result_persistent = True
-CELERY_ENABLE_UTC = True
+result_serializer = "json"
-CELERY_ACCEPT_CONTENT = ["json"]
+task_routes = ("gvacommon.celeryrouters.GvaRouter",)
-CELERY_TASK_SERIALIZER = "json"
+task_serializer = "json"
-CELERY_RESULT_SERIALIZER = "json"
+timezone = "Europe/Berlin"
 ########## END CELERY CONFIGURATION
 
 ########## GVAFILE CONFIGURATION

poetry.lock

@@ -427,14 +427,14 @@ files = [
 
 [[package]]
 name = "importlib-metadata"
-version = "6.0.0"
+version = "4.13.0"
 description = "Read metadata from Python packages"
 category = "main"
 optional = false
 python-versions = ">=3.7"
 files = [
-    {file = "importlib_metadata-6.0.0-py3-none-any.whl", hash = "sha256:7efb448ec9a5e313a57655d35aa54cd3e01b7e1fbcf72dce1bf06119420f5bad"},
+    {file = "importlib_metadata-4.13.0-py3-none-any.whl", hash = "sha256:8a8a81bcf996e74fee46f0d16bd3eaa382a7eb20fd82445c3ad11f4090334116"},
-    {file = "importlib_metadata-6.0.0.tar.gz", hash = "sha256:e354bedeb60efa6affdcc8ae121b73544a7aa74156d047311948f6d711cd378d"},
+    {file = "importlib_metadata-4.13.0.tar.gz", hash = "sha256:dd0173e8f150d6815e098fd354f6414b0f079af4644ddfe90c71e2fc6174346d"},
 ]
 
 [package.dependencies]
@@ -442,7 +442,7 @@ typing-extensions = {version = ">=3.6.4", markers = "python_version < \"3.8\""}
 zipp = ">=0.5"
 
 [package.extras]
-docs = ["furo", "jaraco.packaging (>=9)", "jaraco.tidelift (>=1.4)", "rst.linker (>=1.9)", "sphinx (>=3.5)", "sphinx-lint"]
+docs = ["furo", "jaraco.packaging (>=9)", "jaraco.tidelift (>=1.4)", "rst.linker (>=1.9)", "sphinx (>=3.5)"]
 perf = ["ipython"]
 testing = ["flake8 (<5)", "flufl.flake8", "importlib-resources (>=1.3)", "packaging", "pyfakefs", "pytest (>=6)", "pytest-black (>=0.3.7)", "pytest-checkdocs (>=2.4)", "pytest-cov", "pytest-enabler (>=1.3)", "pytest-flake8", "pytest-mypy (>=0.9.1)", "pytest-perf (>=0.9.2)"]
 
@@ -910,4 +910,4 @@ testing = ["flake8 (<5)", "func-timeout", "jaraco.functools", "jaraco.itertools"
 [metadata]
 lock-version = "2.0"
 python-versions = "^3.7"
-content-hash = "99cbe4f2513f52848ca7d04a1c03d16a8cfb941da7f76a599f1238f3f9e85fae"
+content-hash = "cc5b23fce0286c6c8f1df4926fcb75bbb7e46a54d41e4249f3eb7165ee8214b5"

pyproject.toml

@@ -10,6 +10,7 @@ readme = "README.rst"
 python = "^3.7"
 celery = "^5.2.7"
 redis = "^4.5.1"
+importlib-metadata = "<5"
 
 
 [tool.poetry.group.dev.dependencies]