From 2c50b91b1a580ef4d6c8893d3200bc80896f1789 Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Sat, 23 Jan 2016 20:48:32 +0100 Subject: [PATCH 1/2] Fix performance data output This commit fixes the unit of measure of daysvalid to be conformant to the performance data specification at http://docs.icinga.org/latest/de/perfdata.html#pluginperfdata by omiting the invalid unit 'd' at the end of the value. --- check_xmppng | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check_xmppng b/check_xmppng index da46d7a..052db5c 100755 --- a/check_xmppng +++ b/check_xmppng @@ -2,7 +2,7 @@ # -*- coding: utf-8 -*- # # Nagios compatible check for XMPP servers. -# Copyright (C) 2015 Jan Dittberner +# Copyright (C) 2015-2016 Jan Dittberner # # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -486,7 +486,7 @@ class DaysValidContext(nagiosplugin.Context): def performance(self, metric, resource): if resource.checkcerts and metric.value is not None: - return nagiosplugin.Performance('daysvalid', metric.value, 'd') + return nagiosplugin.Performance('daysvalid', metric.value, '') return None From 6a4254c8a561cca25f093254725fd4e5db9d8f06 Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Sat, 23 Jan 2016 21:10:08 +0100 Subject: [PATCH 2/2] Update changes.md and icingaexchange.yml --- changes.md | 4 ++++ icingaexchange.yml | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/changes.md b/changes.md index fb8ed8f..9920146 100644 --- a/changes.md +++ b/changes.md @@ -1,5 +1,9 @@ # change log +## version 0.2.1 2016-01-23 + +* fix perfdata output for daysvalid metric + ## version 0.2 2015-12-29 * improve human readable output by returning both response time as well as diff --git a/icingaexchange.yml b/icingaexchange.yml index bee5230..4f4c926 100644 --- a/icingaexchange.yml +++ b/icingaexchange.yml @@ -7,6 +7,29 @@ target: Messaging type: Plugin license: gplv3 releases: + - name: 0.2.1 + description: "fixed perfdata output" + files: + - + name: check_xmppng + url: "file:///check_xmppng" + description: "Check command" + checksum: 992ee1b3209bba6ddb29b46c939b2978 + - + name: COPYING + url: "file:///COPYING" + description: "GPL 3.0 license text" + checksum: d32239bcb673463ab874e80d47fae504 + - + name: README.md + url: "file:///README.md" + description: "documentation" + checksum: 1e6f6632b12e4ef5fc4f02c3ea65da8a + - + name: changes.md + url: "file:///changes.md" + description: "change log" + checksum: a7a17e05c732e24f7b0529fb868a172f - name: 0.2 description: "better human readable output" files: