From 67a9c348bd432842b52df0d13725f4e903206cd8 Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Sat, 8 Feb 2014 13:10:59 +0100 Subject: [PATCH] make unit tests more useful - check response in controller unit tests - remove unused imports - bump copyright years - replace "DDPortfolio service" in file headers with "Debian Member Portfolio Service" --- ddportfolioservice/tests/__init__.py | 30 ++++++++----------- .../tests/functional/test_ddportfolio.py | 28 +++++++++-------- .../tests/functional/test_showformscripts.py | 30 ++++++++++--------- 3 files changed, 44 insertions(+), 44 deletions(-) diff --git a/ddportfolioservice/tests/__init__.py b/ddportfolioservice/tests/__init__.py index 0e1d22f..5185497 100644 --- a/ddportfolioservice/tests/__init__.py +++ b/ddportfolioservice/tests/__init__.py @@ -1,24 +1,23 @@ # -*- python -*- # -*- coding: utf-8 -*- # -# DDPortfolio service tests package -# Copyright © 2009, 2010, 2011, 2012 Jan Dittberner +# Debian Member Portfolio Service tests package +# Copyright © 2009-2014 Jan Dittberner # -# This file is part of DDPortfolio service. +# This file is part of Debian Member Portfolio Service. # -# DDPortfolio service is free software: you can redistribute it and/or -# modify it under the terms of the GNU Affero General Public License -# as published by the Free Software Foundation, either version 3 of -# the License, or (at your option) any later version. +# Debian Member Portfolio Service is free software: you can redistribute it +# and/or modify it under the terms of the GNU Affero General Public License as +# published by the Free Software Foundation, either version 3 of the License, +# or (at your option) any later version. # -# DDPortfolio service is distributed in the hope that it will be -# useful, but WITHOUT ANY WARRANTY; without even the implied warranty -# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Affero General Public License for more details. +# Debian Member Portfolio Service is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero +# General Public License for more details. # -# You should have received a copy of the GNU Affero General Public -# License along with this program. If not, see -# . +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see . # """Pylons application test package @@ -30,11 +29,8 @@ pkg_resources, in case the project hasn't been installed with setuptools. It also initializes the application via websetup (paster setup-app) with the project's test.ini configuration file. """ -import os -import sys from unittest import TestCase -from paste.deploy import loadapp from paste.script.appinstall import SetupCommand from pylons import url from routes.util import URLGenerator diff --git a/ddportfolioservice/tests/functional/test_ddportfolio.py b/ddportfolioservice/tests/functional/test_ddportfolio.py index 2a8a6ed..a21feb9 100644 --- a/ddportfolioservice/tests/functional/test_ddportfolio.py +++ b/ddportfolioservice/tests/functional/test_ddportfolio.py @@ -1,24 +1,23 @@ # -*- python -*- # -*- coding: utf-8 -*- # -# DDPortfolio service DdportfolioController test +# Debian Member Portfolio Service DdportfolioController test # Copyright © 2009, 2010 Jan Dittberner # -# This file is part of DDPortfolio service. +# This file is part of Debian Member Portfolio Service. # -# DDPortfolio service is free software: you can redistribute it and/or -# modify it under the terms of the GNU Affero General Public License -# as published by the Free Software Foundation, either version 3 of -# the License, or (at your option) any later version. +# Debian Member Portfolio Service is free software: you can redistribute it +# and/or modify it under the terms of the GNU Affero General Public License as +# published by the Free Software Foundation, either version 3 of the License, +# or (at your option) any later version. # -# DDPortfolio service is distributed in the hope that it will be -# useful, but WITHOUT ANY WARRANTY; without even the implied warranty -# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Affero General Public License for more details. +# Debian Member Portfolio Service is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero +# General Public License for more details. # -# You should have received a copy of the GNU Affero General Public -# License along with this program. If not, see -# . +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see . # from ddportfolioservice.tests import TestController, url @@ -28,3 +27,6 @@ class TestDdportfolioController(TestController): def test_index(self): response = self.app.get(url(controller='ddportfolio', action='index')) # Test response... + assert response.status_int == 200 + assert response.content_type == "text/html" + assert "Debian Member Portfolio Service" in response diff --git a/ddportfolioservice/tests/functional/test_showformscripts.py b/ddportfolioservice/tests/functional/test_showformscripts.py index b8b3347..ff7a6e4 100644 --- a/ddportfolioservice/tests/functional/test_showformscripts.py +++ b/ddportfolioservice/tests/functional/test_showformscripts.py @@ -1,24 +1,23 @@ # -*- python -*- # -*- coding: utf-8 -*- # -# DDPortfolio service DdportfolioController test -# Copyright © 2009, 2010, 2011, 2012 Jan Dittberner +# Debian Member Portfolio Service DdportfolioController test +# Copyright © 2009-2014 Jan Dittberner # -# This file is part of DDPortfolio service. +# This file is part of Debian Member Portfolio Service. # -# DDPortfolio service is free software: you can redistribute it and/or -# modify it under the terms of the GNU Affero General Public License -# as published by the Free Software Foundation, either version 3 of -# the License, or (at your option) any later version. +# Debian Member Portfolio Service is free software: you can redistribute it +# and/or modify it under the terms of the GNU Affero General Public License as +# published by the Free Software Foundation, either version 3 of the License, +# or (at your option) any later version. # -# DDPortfolio service is distributed in the hope that it will be -# useful, but WITHOUT ANY WARRANTY; without even the implied warranty -# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Affero General Public License for more details. +# Debian Member Portfolio Service is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero +# General Public License for more details. # -# You should have received a copy of the GNU Affero General Public -# License along with this program. If not, see -# . +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see . # from ddportfolioservice.tests import TestController, url @@ -29,3 +28,6 @@ class TestShowformscriptsController(TestController): response = self.app.get( url(controller='showformscripts', action='index')) # Test response... + assert response.status_int == 200 + assert response.content_type == "text/javascript" + assert "function updateField" in response