From 7aee6c8838bc8773c272b5d98c82f6337d5ac2aa Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Thu, 25 Dec 2014 23:53:58 +0100 Subject: [PATCH] use full paths for invoked commands --- gvafile/osusers/tasks.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gvafile/osusers/tasks.py b/gvafile/osusers/tasks.py index 65c8091..571046f 100644 --- a/gvafile/osusers/tasks.py +++ b/gvafile/osusers/tasks.py @@ -19,6 +19,10 @@ from gvafile.exceptions import GVAFileException _logger = get_task_logger(__name__) +SUDO_CMD = '/usr/bin/sudo' +INSTALL_CMD = '/usr/bin/install' +SETFACL_CMD = '/usr/bin/setfacl' + def _build_sftp_directory_name(username): """ @@ -53,11 +57,11 @@ def setup_file_sftp_userdir(username): sftp_directory = _build_sftp_directory_name(username) try: subprocess.check_output([ - 'sudo', 'install', '-o', username, '-g', username, '-m', '0750', - '-d', sftp_directory], stderr=subprocess.STDOUT) + SUDO_CMD, INSTALL_CMD, '-o', username, '-g', username, + '-m', '0750', '-d', sftp_directory], stderr=subprocess.STDOUT) subprocess.check_output([ - 'sudo' 'setfacl', '-r', '-m', 'www-data:--x', sftp_directory], - stderr=subprocess.STDOUT) + SUDO_CMD, SETFACL_CMD, '-r', '-m', 'www-data:--x', + sftp_directory], stderr=subprocess.STDOUT) except subprocess.CalledProcessError: _logger.exception( 'could not create SFTP directory for user %s', username)